Added check for bad response in fetch call #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgauss
requested review from
kylelaker,
bwwalshjr,
mikeisen1,
hreineck,
zclarkEDC and
kkennedy26
kylelaker
approved these changes
Feb 2, 2022
zclarkEDC
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #229
See above for how to reproduce locally.
Given the current dependence of our end-to-end tests on a fixed deployment configuration/, it would be difficult to add an automated test for this edge case. If/when we move towards a more robust pipeline for different environments/configurations we can revisit a pipeline test here.