Update dependencies with old dependencies #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a major upgrade for the react-router-dom package and required some pretty fundamental changes to the way our routing and redirects work. For the react-scripts, we just needed to add an additional eslint config package to the package.json
kylelaker
force-pushed
the
feature/update-dependencies
branch
from
fa8c0f0
to
96542db
Compare
There are a ton of eslint packages in our `package-lock.json` that we don't directly use and there are updates to several of them as well. This updates them to the newest cohesive set (we can't move to eslint 8 yet) possible.
A few packages were downgraded and should not have been. This puts them back to the newest compatible version
|
This PR also applies the same versions from (or removes the need for):
As well as several other packages. By updating |
zclarkEDC
reviewed
Feb 14, 2022
| @@ -24,7 +24,7 @@ import { | |||
| } from "@EasyDynamics/oscal-react-library"; | |||
| import logo from "./images/logo-header.svg"; | |||
|
|
|||
| const theme = createMuiTheme({ | |||
| const theme = createTheme({ | |||
There was a problem hiding this comment.
If anyone is wondering why this was changed when reviewing: Material UI Migration from V4 to V5
There was a problem hiding this comment.
Yeah exactly. This wasn't necessarily required but it was a noisy warning (and has been for awhile) and hopefully it'll be one less thing to handle in #244
zclarkEDC
approved these changes
Feb 14, 2022
rgauss
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates a few React-related packages that themselves have a bunch of outdated packages as dependencies. An
npm installafter these changes shows 74 vulnerabilities (59 moderate, 15 high). Before these changes, it is 130 vulnerabilities (107 moderate, 21 high, 2 critical). It's not a massive improvement on the high/critical side but I think it unblocks a few more potential updates