Add support for network and data flow diagrams #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Because of some formatting changes, the diff for this may be slightly better if the "ignore whitespace" option is applied. |
kylelaker
added a commit
that referenced
this pull request
Feb 24, 2022
While working on the implementation for #273 it was unclear to me whether the specification permits diagrams to be referenced directly by URI or not so I split this out into its own pull request. The specification specifically states: > The value of the href can be an internet resource, or a local reference > using a fragment e.g. #fragment that points to a back-matter resource in > the same document. > > If a local reference using a fragment is used, this will be indicated by > a fragment "#" followed by an identifier which references an identified > resource in the document's back-matter or another object that is within > the scope of the containing OSCAL document. > > If an internet resource is used, the href value will be an absolute or > relative URI pointing to the location of the referenced resource. A > relative URI will be resolved relative to the location of the document > containing the link. This, to me, implied that we should be permitting absolute and relative links via a URI to internet resources. To implement this, a "wrapper"-ish function has been created for what used to be a pure Back Matter lookup function. It handles the logic to determine whether the link is internal (needs to be looked up in Back Matter) or an internet resource (is a URI). There are some incidental changes to code and tests due to the changing of imports and addition of exported `test-data`.
rgauss
approved these changes
Feb 24, 2022
zclarkEDC
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mimics the existing behavior for Authorization Boundaries
Closes: #222
Closes: #223