Persist rest mode toggle across page loads #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be clear this does nothing on a refresh (we're not storing this value anywhere) but at least doing:
|
mikeisen1
reviewed
Feb 28, 2022
mikeisen1
approved these changes
Mar 1, 2022
|
This is ready to merge but I've moved it to draft because:
|
This makes the configuration of "rest mode" an app-level configuration that is a parameter to the library components. This matches with how the Google Analytics is set; additionally, it means that the environment variable should be set when building the app and that this isn't a decision made when compiling the library (so it doesn't have to be set in the CI pipeline!).
kylelaker
force-pushed
the
feature/persist-rest-mode-config
branch
from
88eb114
to
e6b63ba
Compare
|
Rebased and ready to go! |
rgauss
approved these changes
Mar 3, 2022
Co-authored-by: Ray Gauss II <rgauss@easydynamics.com>
|
@mikeisen1 I see that you re-requested yourself for review. Is there something in particular here you'd like to see changed or can we go ahead and merge this? |
I re-requested a review after seeing your comments on needing to rebase this PR. But everything looks good to go, so I'll go ahead and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the configuration of "rest mode" an app-level configuration
that is a parameter to the library components. This matches with how the
Google Analytics is set; additionally, it means that the environment
variable should be set when building the app and that this isn't a
decision made when compiling the library (so it doesn't have to be set
in the CI pipeline!).