Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added silent fail on unresolved diagram resources #285

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Added silent fail on unresolved diagram resources #285

merged 1 commit into from
Mar 1, 2022

Conversation

rgauss
Copy link
Contributor

@rgauss rgauss commented Mar 1, 2022

Fixes #284

@rgauss rgauss requested a review from a team March 1, 2022 02:29
kylelaker
kylelaker approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@kylelaker kylelaker left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might eventually (not in this bug fix) be a good use case for either the onError of <img> or our ErrorBoundary with a custom fallback.

I don't at all want to slow down getting this bug fix in.

@kylelaker kylelaker requested a review from a team March 1, 2022 03:53
@mikeisen1 mikeisen1 merged commit 2ceef97 into develop Mar 1, 2022
@rgauss rgauss deleted the fix/resource-errors branch March 2, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylelaker kylelaker kylelaker approved these changes

@mikeisen1 mikeisen1 mikeisen1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SSP Viewer Fails to Load on Unresolvable Resources
3 participants
@rgauss @kylelaker @mikeisen1