Handle errors during URL fetching #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylelaker
requested review from
rgauss,
zclarkEDC,
hreineck,
kkennedy26 and
a team
|
An earlier version of this work did leverage e7c9642 but this current implementation doesn't. I am going to rebase this work to split that commit into its own PR and cleanup the history on this PR. |
kylelaker
force-pushed
the
feature/fix-unhandled-errors
branch
from
ac8bfa7
to
d19be32
Compare
|
Samples of a few different error types; both ones fixed by #267 and ones that worked before (and some that worked after), some occur in the 404 URL: No CORS: 200 with a non-JSON response ( SSP passed to the Catalog Viewer: |
kylelaker
force-pushed
the
feature/fix-unhandled-errors
branch
from
d19be32
to
20dd12e
Compare
Because `OSCALLoader` itself is the top-level component that has an `<ErrorBoundary>` as a child, we cannot rely on the `<ErrorBoundary>` to catch errors further in the stack. Additionally, Error Boundaries do a poor job of catching asynchronous errors. Instead, we track error state (which we did prior to #267, though, this implementation is a little cleaner as we don't try to pass the `onError` further down the call stack since we _can_ use the `<ErrorBoundary>` for that. Since we've refactored the logic to handle the error into its own (reused) function, it's now also trivial to set the `loaded` and `isResolutionComplete` variables, which means we can also re-enable the "Reload" button even after an error. Resolves #283 Resolves #163
kylelaker
force-pushed
the
feature/fix-unhandled-errors
branch
from
20dd12e
to
e738eca
Compare
rgauss
approved these changes
Mar 1, 2022
We actually have no means to "look into it" (right now).
kylelaker
commented
Mar 1, 2022
This allows displaying a more friendly error text but also expanding it to view the specific details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
OSCALLoaderitself is the top-level component that has an<ErrorBoundary>as a child, we cannot rely on the<ErrorBoundary>tocatch errors further in the stack. Additionally, Error Boundaries do a
poor job of catching asynchronous errors. Instead, we track error state
(which we did prior to #267, though, this implementation is a little
cleaner as we don't try to pass the
onErrorfurther down the callstack since we can use the
<ErrorBoundary>for that.Since we've refactored the logic to handle the error into its own
(reused) function, it's now also trivial to set the
loadedandisResolutionCompletevariables, which means we can also re-enable the"Reload" button even after an error.
Resolves #283
Resolves #163