-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for release #300
Merged
Prepare for release #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kylelaker
commented
Mar 2, 2022
- Add react-split library.
- Update OSCALLoader components.
- Update App.js.
- Add @monaco-editor/react pacakge.
- Add OSCALJsonEditor.js.
- Update OSCALLoader component.
- Update App.js.
- Update OSCALLoader.js.
- Update OSCALJsonEditor.js.
- Update OSCALLoader.css.
- Update package-lock.json.
- Add OSCALJsonEditor.js.
- Update OSCALLoader.js.
- Update OSCALLoader.js.
- Add support for PUT method
- Fix spacing issues
- Add OSCALLoaderStyles.js
- Update useLoaderStyles
- Update OSCALJsonEditor.js
- Update OSCALLoader.js
- Update OSCALLoaderForm.js
- Update OSCALMetadata.js
- Update OSCALJsonEditor.js
- Update OSCALLoader.js
- Update OSCALLoaderForm.js
- Bump actions/setup-node from 2 to 3
- Bump react-router-dom from 6.2.1 to 6.2.2
- Bump version to 0.4.0-0
- Update OSCALLoader.js
- Bump actions/checkout from 2 to 3
- Bump actions/delete-package-versions from 2.0.1 to 2.0.2
- Preserved oscalSource and UI Changes
- Fix linting
- Track the v2 release series as a whole
Added conditional checks for `isRestMode` and added the react-split control so that when `isRestMode` is `true` the `OSCALLoader` component will render a split pane.
The `maxWidth` value of `xl` was added which overrides the default of large. This was done so that the JSON editor can be accomodated in the application.
The split pane defaults were updated so that the JSON Editor and viewer share a 50/50 split. The `minSize` value was also updated to 500 as a sensible default, because collapsing a pane to 0 can cause issues.
The updates improve the look and feel based on the margins and grid layout. The editor was also made sticky so that it follows veritical scrolling.
Removed overflow attributes, since they cause conflicts with sticky HTML elements.
The split pane defaults were updated so that the JSON Editor and viewer share a 50/50 split. The `minSize` value was also updated to 500 as a sensible default, because collapsing a pane to 0 can cause issues.
The split pane defaults were updated so that the JSON Editor and viewer share a 50/50 split. The `minSize` value was also updated to 500 as a sensible default, because collapsing a pane to 0 can cause issues.
…eact-library into feature/json-editor
Update layout of editor, hide `resolvedControls` attribute, and minor changes that improve testing. Tests were added in OSCALJsonEditor.test.js.
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 2 to 3. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v2...v3) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [react-router-dom](https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom) from 6.2.1 to 6.2.2. - [Release notes](https://github.com/remix-run/react-router/releases) - [Commits](https://github.com/remix-run/react-router/commits/v6.2.2/packages/react-router-dom) --- updated-dependencies: - dependency-name: react-router-dom dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
This sets the prelease field to `-0` to signify that it is a prerelease of `0.4.0`. The next tagged version will be `0.4.0`.
Bump version to 0.4.0-0
…ct-router-dom-6.2.2 Bump react-router-dom from 6.2.1 to 6.2.2
This change adds the a `Fab` button that floats over the enitre viewer via a toolbar. Upon clicking the button, the JSON editor is toggled to either be displayed or hidden.
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v3) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/delete-package-versions](https://github.com/actions/delete-package-versions) from 2.0.1 to 2.0.2. - [Release notes](https://github.com/actions/delete-package-versions/releases) - [Commits](actions/delete-package-versions@v2.0.1...v2.0.2) --- updated-dependencies: - dependency-name: actions/delete-package-versions dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…ctions/setup-node-3 Bump actions/setup-node from 2 to 3
Preserved oscalSource and UI Changes
…ctions/checkout-3 Bump actions/checkout from 2 to 3
…ctions/delete-package-versions-2.0.2 Bump actions/delete-package-versions from 2.0.1 to 2.0.2
Add OSCALJsonEditor Component
rgauss
approved these changes
Mar 2, 2022
Moved to draft to prevent accidental merge before #299 is ready. Please still approve. |
rgauss
approved these changes
Mar 2, 2022
zclarkEDC
approved these changes
Mar 2, 2022
Update version to 0.4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.