[EGRC-268] Establish Linting and Address Issues in OSCAL Viewer

[zclarkEDC]

Overview

Set up ESLint to enforce the Airbnb React Style Guide.
Any linting errors will cause npm start and npm run build to fail.

Installation

npm install
npm run lint to see any errors.

Issues

There were over 400 problems that could not be solved with --fix linting command.
Many of these issues were resolved with rules in eslintrc.json:

 "rules": {
      "react/jsx-filename-extension": [1, { "extensions": [".js", ".jsx"] }],
      "react/prop-types": [0],
      "react/destructuring-assignment": [0],
      "no-unused-vars": "off",
      "no-shadow": "off",
      "react/jsx-props-no-spreading": "off"
      
    },

To see the issues in the console for yourself, just delete these rules and run npm run lint in the console.

Props issues

react/prop-types was especially troubling: any instance of props needed validation with PropTypes, and had to be destructured into individual variables.
It would require a massive amount of refactoring, basically every component would have to be rewritten and how props are passed between components would have to change.

For loops

The airbnb style guide is explicitly against using for loops, throwing a no-restricted-syntax at them.
There are instances of /* eslint-disable */

• OSCALCatalog.js
• OSCALControl .js
• OSCALControlPart.js
• OSCALMetadata.js

[rgauss]

@zclarkEDC, can you create a Jira task along the lines of 'Re-Evaluate Linting Workarounds...'.

Some of the rules we're disabling seem like they should be addressed, but getting the consistency this PR addresses in place first is important.

@kkennedy26, if this goes in before the component PR(s) you may have to address any linting errors.