Use pull_request event for dependency-pr flow
#340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Opened a PR to fix the docs as well at github/docs#16752 |
|
If this actually fixes our issues, I will remove the |
kylelaker
force-pushed
the
feature/fix-dep-pr-event
branch
from
2d62afa
to
867e639
Compare
The GitHub docs say that the event is `pull_request_target`; however, that does not exist as an object on the event. The `pull_request` object is there and we should use that.
kylelaker
force-pushed
the
feature/fix-dep-pr-event
branch
from
867e639
to
2561531
Compare
zclarkEDC
approved these changes
Apr 1, 2022
rgauss
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GitHub docs say that the event is
pull_request_target; however,that does not exist as an object on the event. The
pull_requestobjectis there and we should use that.
Related to #321