Remove GitHub Super-Linter #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylelaker
force-pushed
the
feature/update-eslint-config
branch
2 times, most recently
from
9e74da8
to
dd5b82d
Compare
kylelaker
changed the title
kylelaker
force-pushed
the
feature/update-eslint-config
branch
from
dd5b82d
to
6aab4de
Compare
We've run into issues in the past with the super linter. It evaluates file one-by-one rather how developers run tests. When run against the entire codebase it's extremely slow; this causes issues because it means that configuration changes that may break linting aren't caught (since rarely do code files get modified at the same time as linting configuration files). We've had issues with breaking changes in tools used for linting (such as migrating from jsonlint to eslint). We lint JSON and JavaScript with `npm run lint`. The only thing we meaningfully lint outside that is Markdown and YAML. Both of these are pretty easy to just use the actual tools that Super-Linter is running anyway. We might be able to integrate markdownlint into our `npm lint` workflow but we can't for yamllint (since it's a Python package) so there's not much value in that as far as I can see.
kylelaker
force-pushed
the
feature/update-eslint-config
branch
from
6aab4de
to
0b81254
Compare
zclarkEDC
approved these changes
Apr 4, 2022
hreineck
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've run into issues in the past with the super linter. It evaluates
file one-by-one rather how developers run tests. When run against the
entire codebase it's extremely slow; this causes issues because it means
that configuration changes that may break linting aren't caught (since
rarely do code files get modified at the same time as linting
configuration files). We've had issues with breaking changes in tools
used for linting (such as migrating from jsonlint to eslint).
We lint JSON and JavaScript with
npm run lint. The only thing wemeaningfully lint outside that is Markdown and YAML. Both of these are
pretty easy to just use the actual tools that Super-Linter is running
anyway.
We might be able to integrate markdownlint into our
npm lintworkflowbut we can't for yamllint (since it's a Python package) so there's not
much value in that as far as I can see.