Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin react-refresh to 0.11.0 #384

Merged
merged 1 commit into from
May 4, 2022
Merged

Conversation

kylelaker
Copy link
Contributor

When there are conflicting versions of react-refresh, npm run start
seems to lose its mind (well, not that command directly but something
way deep down in react-scripts that's responsible for actually running
the dev server).

For now, let's pin it to 0.11.0 so that people can actually develop and
work. And we can evaluate removing this. The conflicting version that
seems to be coming up at the moment is 0.13.0. We probably could have
picked that version too but this is what most the app was resolving and
so that feels safer.

When there are conflicting versions of `react-refresh`, `npm run start`
seems to lose its mind (well, not that command directly but something
way deep down in `react-scripts` that's responsible for actually running
the dev server).

For now, let's pin it to 0.11.0 so that people can actually develop and
work. And we can evaluate removing this. The conflicting version that
seems to be coming up at the moment is 0.13.0. We probably could have
picked that version too but this is what most the app was resolving and
so that feels safer.
@easy-dynamics-oscal-automation easy-dynamics-oscal-automation bot requested a review from a team May 3, 2022 21:51
@kylelaker
Copy link
Contributor Author

Because this necessitated deleting package-lock.json and node_modules a few other dependencies got updated.

@easy-dynamics-oscal-automation easy-dynamics-oscal-automation bot requested a review from a team May 4, 2022 12:05
@rgauss
Copy link
Contributor

rgauss commented May 4, 2022

I believe this is the error you'd see:

Module not found: Error: You attempted to import /Users/rgauss/Code/oscal-react-library/node_modules/react-refresh/runtime.js which falls outside of the project src/ directory. Relative imports outside of src/ are not supported.
You can either move it inside src/, or add a symlink to it from project's node_modules/.
ERROR in ./src/App.js 1:40-127
Module not found: Error: You attempted to import /Users/rgauss/Code/oscal-react-library/node_modules/react-refresh/runtime.js which falls outside of the project src/ directory. Relative imports outside of src/ are not supported.
You can either move it inside src/, or add a symlink to it from project's node_modules/.

ERROR in ./src/index.js 1:40-127
Module not found: Error: You attempted to import /Users/rgauss/Code/oscal-react-library/node_modules/react-refresh/runtime.js which falls outside of the project src/ directory. Relative imports outside of src/ are not supported.
You can either move it inside src/, or add a symlink to it from project's node_modules/.

ERROR in ./src/reportWebVitals.js 1:40-127
Module not found: Error: You attempted to import /Users/rgauss/Code/oscal-react-library/node_modules/react-refresh/runtime.js which falls outside of the project src/ directory. Relative imports outside of src/ are not supported.
You can either move it inside src/, or add a symlink to it from project's node_modules/.

webpack compiled with 3 errors

@mikeisen1, @hreineck, @zclarkEDC, this currently blocks development, please review.

@zclarkEDC zclarkEDC merged commit fa0f623 into develop May 4, 2022
@zclarkEDC zclarkEDC deleted the feature/pin-react-refresh branch May 4, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants