Support editing metadata for all document types #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows editing metadata for each of the existing document types. Because the metadata is a totally shared (and root) object and because all the base objects server-side support a `PATCH` operation, this is a pretty easy change to patch in. All other changes have to be made via the JSON editor. This _is not_ yet ready to be merged. It is going to have conflicts (well, conflicts really are the best case; more likely, this will silently break) with other open PRs but this gives a starting point for making the modifications. Eventually, we can probably patch through a few other editable types from an SSP to other documents that reuse those components. But again, this is easy and its available now so I figured why not go for it.
|
If we decide to move forward with this, it needs to wait until at least after #277 |
rgauss
approved these changes
May 11, 2022
mikeisen1
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows editing metadata for each of the existing document types.
Because the metadata is a totally shared (and root) object and because
all the base objects server-side support a
PATCHoperation, this is apretty easy change to patch in. All other changes have to be made via
the JSON editor.
This is not yet ready to be merged. It is going to have conflicts
(well, conflicts really are the best case; more likely, this will
silently break) with other open PRs but this gives a starting point for
making the modifications.
Eventually, we can probably patch through a few other editable types
from an SSP to other documents that reuse those components. But again,
this is easy and its available now so I figured why not go for it.