Use npm update instead of deleting package-lock.json
#394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we update packages, it's usually a bit better to keep package-lock.json and to run `npm install && npm update` instead.
|
The inspiration for this was mostly wanted to make sure that the SHA hash changes we see in #393 would have happened with Usually SHA-only changes are a red flag but in #393's case, it's because they're changing from SHA1 to SHA512. |
rgauss
approved these changes
May 17, 2022
mikeisen1
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we update packages, it's usually a bit better to keep
package-lock.json and to run
npm install && npm updateinstead.