Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented REST success, existing param handling #396

Merged
merged 1 commit into from
May 18, 2022

Conversation

rgauss
Copy link
Contributor

@rgauss rgauss commented May 18, 2022

Creates a handleRestSuccess function and sends that to OSCAL root object renderers as the onRestSuccess property. In the case of OSCALSsp that is passed down to OSCALControlProse and subsequently OSCALRestUtils which executes it on success.

For now the handleRestSuccess simply reloads the entire page. In the future we'll likely want to investigate better re-rendering of specific components.

This also resolves an issue where the set-parameters were being added to the implementedRequirements object rather than replacing an existing one.

@easy-dynamics-oscal-automation easy-dynamics-oscal-automation bot requested a review from a team May 18, 2022 12:35
@kylelaker
Copy link
Contributor

Eventually for UX reasons, we probably want to consider ways to handle this that aren't as jarring as reloading the whole page (just the component(s) that changed) but this looks good for now!

@rgauss
Copy link
Contributor Author

rgauss commented May 18, 2022

Eventually for UX reasons, we probably want to consider ways to handle this that aren't as jarring as reloading the whole page (just the component(s) that changed) but this looks good for now!

Yes, I edited the description this morning with something similar after you had already approved the PR.

@mikeisen1 mikeisen1 merged commit e84a419 into develop May 18, 2022
@mikeisen1 mikeisen1 deleted the fix/on-rest-success branch May 18, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants