[EGRC-292] Update OSCAL SSP Viewer, resolve various bugs related oscal-content update

[zclarkEDC]

Overview

EGRC-292

Render fix

Still using the variable name annotations, because props is already assigned.

If we do a PropTypes rewrite in the future, this may alleviate the issue.

404 Error fix

In OSCALSspResolver.js, changed the relative profile import path.
This fix is needed because latest oscal-content PR resolved the issue

[kkennedy26]

Files look good. Ran OSCALViewer locally and navigated to system security plan viewer. Looks good

[rgauss]

Minor change requested.

[zclarkEDC]

@rgauss @kkennedy26
The text not highlighting inside of Control Implementation is due to a change in how the NIST_SP-800-53_rev4_MODERATE-baseline_profile.json imports controls.

Old version:

"include": {
          "calls": [
            {
              "control-id": "ac-1"
            },
            {
              "control-id": "ac-2"
            },
            {
              "control-id": "ac-2.1"
            },
            {
              "control-id": "ac-2.2"
            },

New version

"include-controls": [
          {
            "with-ids": [
              "ac-1",
              "ac-2",
              "ac-2.1",
              "ac-2.2",

To fix this issue, OSCALControlImplementationReq must be changed, specifically how it imports controls:

  const control = props.controls.find(
    (control) => control.id === props.implementedRequirement["control-id"]
  );

[rgauss]

@zclarkEDC, that looks correct to me, go for it.

[rgauss]

@zclarkEDC, looks like the issue is actually an issue with the addition of insert: param, in the recent commit changing the catalog which will probably need changes to code such as ReplacedProseWithParameterLabel and ReplacedProseWithByComponentParameterValue.

Note that the Catalog Viewer parameter label is broken as well.

[zclarkEDC]

Note that the Catalog Viewer parameter label is broken as well.

I spent some time attempting to fix the issue if there are 2 {{insert: param, paramId}} in the same prose, but it caused load times to take minutes.

I left a comment elaborating on the issue near the old // TODO

[zclarkEDC]

@rgauss
From catalog

prose": "Review and update the current access control:",
                    "parts": [
                      {
                        "id": "ac-1_smt.c.1",
                        "name": "item",
                        "props": [
                          {
                            "name": "label",
                            "value": "1."
                          }
                        ],
                        "prose": "Policy {{ insert: param, ac-1_prm_4 }} and following {{ insert: param, ac-1_prm_5 }}; and"
                      },
                      {
                        "id": "ac-1_smt.c.2",
                        "name": "item",
                        "props": [
                          {
                            "name": "label",
                            "value": "2."
                          }
                        ],
                        "prose": "Procedures {{ insert: param, ac-1_prm_6 }} and following {{ insert: param, ac-1_prm_7 }}."
                      }

In "prose": "Policy {{ insert: param, ac-1_prm_4 }} and following {{ insert: param, ac-1_prm_5 }}; and"
Currently our code only catches the first param, and old code would break if there were 2 params.
Setting up a separate rawProse and extracting each param by using a while loop made the app take about 2 full minutes to open the Access Control tab.