Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit Editable Text Field edit state on escape key press #432

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

mikeisen1
Copy link
Contributor

As #270 states, we want to improve the usability of the OSCALEditableTextField. Part of the improvements require whenever that component is in an edit state, we want to exit the edit state when the escape key is pressed.

closes #431

@mikeisen1 mikeisen1 added the enhancement New feature or request label Jun 9, 2022
@mikeisen1 mikeisen1 requested review from nuttercd, kperk103, schen2166 and a team June 9, 2022 21:16
@mikeisen1 mikeisen1 self-assigned this Jun 9, 2022
@easy-dynamics-oscal-automation easy-dynamics-oscal-automation bot requested a review from a team June 10, 2022 12:44
@Bronstrom Bronstrom merged commit b40b911 into develop Jun 10, 2022
@Bronstrom Bronstrom deleted the feature/esc-exits-editable-text-field branch June 10, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request subtask
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subtask: OSCALEditableTextField Handle Exit on Esc
3 participants