Eliminate unique key prop errors #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`OSCALReplacedProseWithParameter` Label was producing a unique key prop error when running tests and using the viewer. If `constraintsDisplay` was null, `getParameterLabelSegment()` would return a `Fragment` without a unique key. Rather than giving the `Fragment` a key, you can safely just remove the `Fragment`.
tuckerzp
force-pushed
the
feature/fix-console-warnings
branch
from
cea77d2
to
b4325e6
Compare
tuckerzp
commented
Jun 14, 2022
kylelaker
suggested changes
Jun 15, 2022
kylelaker
reviewed
Jun 15, 2022
OSCALReplacedProseWithByComponentParameterValue was producing a unique key prop error due to the TextField not including a key.
tuckerzp
force-pushed
the
feature/fix-console-warnings
branch
from
b4325e6
to
0150240
Compare
kylelaker
approved these changes
Jun 15, 2022
Bronstrom
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the
unique key prop errorsin bothnpm run testlogs and the example viewer. For now, it does useindexas a key. It was unclear what a better value for a key would be in both places, so if there is any suggestions I will happily try out other values.This should close #425