Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aria label to OSCALEditableTextField #447

Merged
merged 2 commits into from
Jun 15, 2022
Merged

Add aria label to OSCALEditableTextField #447

merged 2 commits into from
Jun 15, 2022

Conversation

nuttercd
Copy link
Contributor

To increase user accessability it is important to have aria lables

@easy-dynamics-oscal-automation easy-dynamics-oscal-automation bot requested a review from a team June 15, 2022 14:57
kylelaker
kylelaker suggested changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@kylelaker kylelaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! But I think that there's more that we need to do here. Let's discuss a bit and see if we can make this even better

src/components/OSCALEditableTextField.js Outdated Show resolved Hide resolved
@nuttercd
Add aria label to OSCALEditableTextField
45b1390 
To increase user accessability it is important to have aria lables
kylelaker
kylelaker suggested changes Jun 15, 2022
View reviewed changes
example/package-lock.json Outdated Show resolved Hide resolved
@easy-dynamics-oscal-automation easy-dynamics-oscal-automation bot requested a review from a team June 15, 2022 17:35
@Bronstrom Bronstrom merged commit 830f430 into develop Jun 15, 2022
@Bronstrom Bronstrom deleted the feature/aria-labels branch June 15, 2022 18:08
@tuckerzp tuckerzp linked an issue Jun 21, 2022 that may be closed by this pull request
Subtask: aria-label attributes contain human-readable text within OSCALEditableTextField and its children #443
Closed
@kylelaker kylelaker added the bug Something isn't working label Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylelaker kylelaker kylelaker approved these changes

@Bronstrom Bronstrom Bronstrom approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subtask: aria-label attributes contain human-readable text within OSCALEditableTextField and its children
3 participants
@nuttercd @kylelaker @Bronstrom