Eliminate all descendant of <p> warnings
#448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So while this may not have broken anything visually, does it change the semantic meaning of any these in a breaking way? Like, are there situations now in the viewer or editor where we have text floating around directly inside a |
tuckerzp
force-pushed
the
feature/descendant-of-p-error-fix
branch
from
f3ca25b
to
6be0e93
Compare
tuckerzp
changed the title
kylelaker
suggested changes
Jun 15, 2022
The Typography wrapped around the TextField in OSCALEditableTextField was causing a console warning. After removing the Typography, the console error disappeared without causing any issue with the tests or viewer. The same issue also occured in OSCALControlProse. proseDisplay can sometimes be a TextField, causing the same warning. Removing the Typography fixes the warning without any apparent side effects.
tuckerzp
force-pushed
the
feature/descendant-of-p-error-fix
branch
from
6be0e93
to
fc808f4
Compare
kylelaker
approved these changes
Jun 15, 2022
Bronstrom
approved these changes
Jun 15, 2022
kylelaker
changed the title
<p> warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will eliminate all descendant of
<p>related console warnings. To dealwith this issue, there were a couple places where
Typographytags weredeleted. After running the tests and looking at the viewer, I am fairly certain
it did not break anything. But it would be good to double check that.
This will close #426