-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EGRC-293: Initial Component Control Implementation UI #45
Conversation
…g process tracking
Reusable and Recursive Profile or Catalog Import
Test is failing on CodeBuild, no linting issues though!
|
@kkennedy26 @rgauss It seems that the Reload button causes the page to crash |
@zclarkEDC, that doesn't seem to be unique to this branch. Can you file a separate bug for that please? |
Gotcha, I'll make a separate bug for it. |
@kkennedy26, will the fixes for the broken test go into this PR? |
@rgauss, yes I will put the fixes for the test specific to this branch in this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good after running locally, and the checks on codebuild are passing. I am approving this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change requested.
Will have to run: npm run lint before npm start to resolve end of line linting errors.