Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EGRC-293: Initial Component Control Implementation UI #45

Merged
merged 22 commits into from
May 7, 2021
Merged

Conversation

kkennedy26
Copy link
Contributor

Will have to run: npm run lint before npm start to resolve end of line linting errors.

@zclarkEDC
Copy link
Member

Test is failing on CodeBuild, no linting issues though!

FAIL src/OSCALComponentDefinition.test.js
--
138 | ● Console
139 |  
140 | console.error
141 | Warning: OSCALComponentDefinitionComponent: `key` is not a prop. Trying to access it will result in `undefined` being returned. If you need to access the same value within the child component, you should pass it as a different prop. (https://reactjs.org/link/special-props)
142 | at OSCALComponentDefinitionComponent (/codebuild/output/src662676869/src/github.com/EasyDynamics/oscal-viewer/src/OSCALComponentDefinitionComponent.js:31:19)
143 | at div
144 | at OSCALComponentDefinition (/codebuild/output/src662676869/src/github.com/EasyDynamics/oscal-viewer/src/OSCALComponentDefinition.js:17:29)
145 |  
146 | 50 \|                   </TableHead>
147 | 51 \|                   <TableBody>
148 | > 52 \|                     <TableRow key={props.key}>
149 | \|                                          ^
150 | 53 \|                       <TableCell component="th" scope="row">
151 | 54 \|                         <Tooltip title={props.component.description}>
152 | 55 \|                           <Typography variant="body2">
153 |  
154 | at printWarning (node_modules/react/cjs/react-jsx-dev-runtime.development.js:117:30)
155 | at error (node_modules/react/cjs/react-jsx-dev-runtime.development.js:93:5)
156 | at Object.key (node_modules/react/cjs/react-jsx-dev-runtime.development.js:693:9)
157 | at OSCALComponentDefinitionComponent (src/OSCALComponentDefinitionComponent.js:52:42)
158 | at renderWithHooks (node_modules/react-dom/cjs/react-dom.development.js:14985:18)
159 | at mountIndeterminateComponent (node_modules/react-dom/cjs/react-dom.development.js:17811:13)
160 | at beginWork (node_modules/react-dom/cjs/react-dom.development.js:19049:16)
161 | at beginWork$1 (node_modules/react-dom/cjs/react-dom.development.js:23940:14)
162 |  
163 | console.error
164 | Error: Uncaught [TypeError: Cannot read property 'forEach' of undefined]

@zclarkEDC
Copy link
Member

@kkennedy26 @rgauss It seems that the Reload button causes the page to crash
reload button uh oh
reload button uh oh 2
This is also a problem on the System Security Plan Viewer, but does not occur on the Catalog viewer.

@rgauss
Copy link
Contributor

rgauss commented May 7, 2021

@kkennedy26 @rgauss It seems that the Reload button causes the page to crash
reload button uh oh
reload button uh oh 2
This is also a problem on the System Security Plan Viewer, but does not occur on the Catalog viewer.

@zclarkEDC, that doesn't seem to be unique to this branch. Can you file a separate bug for that please?

@zclarkEDC
Copy link
Member

zclarkEDC commented May 7, 2021

@kkennedy26 @rgauss It seems that the Reload button causes the page to crash
reload button uh oh
reload button uh oh 2
This is also a problem on the System Security Plan Viewer, but does not occur on the Catalog viewer.

@zclarkEDC, that doesn't seem to be unique to this branch. Can you file a separate bug for that please?

Gotcha, I'll make a separate bug for it.
EDIT: link to bug issue https://easydynamics.atlassian.net/browse/EGRC-298

@rgauss
Copy link
Contributor

rgauss commented May 7, 2021

@kkennedy26, will the fixes for the broken test go into this PR?

@kkennedy26
Copy link
Contributor Author

@rgauss, yes I will put the fixes for the test specific to this branch in this PR

Copy link
Member

@zclarkEDC zclarkEDC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after running locally, and the checks on codebuild are passing. I am approving this PR.

Copy link
Contributor

@rgauss rgauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change requested.

src/OSCALComponentDefinition.js Outdated Show resolved Hide resolved
@kkennedy26 kkennedy26 merged commit 6198667 into develop May 7, 2021
@rgauss rgauss deleted the EGRC-293 branch May 12, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants