Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tooltips to EditableFieldActions icons #453

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Conversation

kperk103
Copy link
Contributor

This will enhance usability of edit, save, and cancel
icons. Additionally, this adds tests for the tooltips.

This closes #441

This will enhance usability of edit, save, and cancel
icons. Additionally, this adds tests for the tooltips.
@easy-dynamics-oscal-automation easy-dynamics-oscal-automation bot requested a review from a team June 17, 2022 17:29
Copy link
Contributor

@kylelaker kylelaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on your first PR @kperk103!! This looks great! I am looking forward to more contributions in the future.

The new tooltips are super helpful for adding context to these icons. Great work!

@easy-dynamics-oscal-automation easy-dynamics-oscal-automation bot requested a review from a team June 20, 2022 00:15
Copy link
Contributor

@tuckerzp tuckerzp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this @kperk103! It looks fantastic.

@tuckerzp tuckerzp merged commit b93f808 into develop Jun 21, 2022
@tuckerzp tuckerzp deleted the feature/add-tooltip branch June 21, 2022 12:37
@kylelaker kylelaker added the enhancement New feature or request label Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subtask: Add Tooltips to Icons for OSCALEditableTextField
3 participants