Add Legend for Parameter Color-Coding #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zclarkEDC
suggested changes
Jun 21, 2022
src/components/OSCALComponentDefinitionControlImplementation.test.js
Outdated
Show resolved
Hide resolved
tuckerzp
suggested changes
Jun 21, 2022
There was a problem hiding this comment.
This looks great so far! I noticed that running npm run test does produce some warnings. I'd love to get this dealt with before merging into develop.
I only looked into it a bit and do not see any obvious issues. From experience, I'd look into places where <div> is placed into a <Typography>.
tuckerzp
reviewed
Jun 21, 2022
tuckerzp
approved these changes
Jun 23, 2022
zclarkEDC
approved these changes
Jun 24, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to enhance user experience, a parameter legend is displayed highlighting the difference between parameter placeholders (orange) and parameter values (blue).
This adds a legend to all control grouping schemes:
OSCALCatalogGroup,OSCALControlImplementation,OSCALComponentDefinitionControlImplementation, andOSCALProfilegroups. The componentOSCALControlParamLegendis built for purposes of avoiding duplicate code. In addition,react-testing-librarytests are written to determine the legend displays in each of the control groupings.Resolves #195, resolves #428, resolves #427