-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Friendly URLs for documents #478
Conversation
Rather than loading by OscalURL's in the editor, we now load based on the OSCALObjects uuid. This allows for a lot more coherent way of routing throughout the editor. It also allows you to load an element by placing the uuid in the url.
4051f06
to
d525a5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the whole... wow! Love it! I think there are some small adjustments we can make to reduce duplication further.
Okay so it looks like there is an odd behavior here. Steps to Reproduce
Expected BehaviorThe page is blank except for the LoaderForm. Actual BehaviorThe previous document remains on the page. |
I agree that it doing that would make sense but I am not 100% sure this is an issue that needs to be solved here. #472 will get rid of the ability to click on a With that said, I also think that what we push to develop should be a working version of the editor. But it seems that I am fully open to working on fixing this, I just wanted to be sure that it is something worth fixing on this pr. |
I agree the actual behavior is odd, but with it being carried over from |
@tuckerzp Please ensure that all supporting PRs on other repos are merged before we merge this in. Tests in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great to me and I like the choices made to limit redundancy with the app bar and navigation routes! It appears all supporting PRs (titled as "Support Friendly URLs" across other repos) have been merged, so I will go ahead and merge this PR.
Rather than loading by OscalURL's in the editor, we now load based on
the OSCALObjects uuid. This allows for a lot more coherent way of
routing throughout the editor. It also allows you to load an element by
placing the uuid in the url.
This may render some portions of the
OSCALLoader
redundant. As I still do notfeel completely confident on what everything in the
OSCALLoader
does, pleasepay extra attention in case I missed something.
Testing still needs to be added to this, but the functionality should
be working. It makes more sense to deal with this testing in EasyDynamics/oscal-editor-deployment#98
Closes #336