Safely handle undefined fields in profile resolution #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Various fields in the OSCAL specification are not required (these are fields that allow [0, 1] elements). In many cases, we were expecting those fields to be present. When loading the NIST SP 800-53 rev5 profiles in our viewer, they would fail to render because we required modify to be present. This makes some minor changes to profile resolution in order to prevent similar issues; a more holistic approach to resolution is certainly still required.
kylelaker
force-pushed
the
feature/fix-errors-in-new-cdef
branch
from
3e643fc
to
6298838
Compare
tuckerzp
approved these changes
Jul 7, 2022
Bronstrom
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various fields in the OSCAL specification are not required (these are
fields that allow [0, 1] elements). In many cases, we were expecting
those fields to be present. When loading the NIST SP 800-53 rev5
profiles in our viewer, they would fail to render because we required
modify to be present.
This makes some minor changes to profile resolution in order to prevent
similar issues; a more holistic approach to resolution is certainly
still required.