Fix Component Viewer When Invalid URLs are Loaded #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuckerzp
requested review from
rgauss,
kylelaker,
folksgl,
zclarkEDC and
kkennedy26
rgauss
approved these changes
Jun 14, 2021
|
This probably should have gone straight into the |
OSCALLoader did not catch errors thrown in OSCALComponentDefinition. When created, OSCALComponentDefinition is now passed an onError() function. OSCALLoader catches that error and displays the existing, defined error of: "Something went wrong loading the OSCAL data"
OSCALComponentDefinition was setting the error and did nothing with it when resolving sources. It now throws the error to OSCALLoader.
|
@rgauss with @kylelaker's help, I changed the branch we are merging into to |
kkennedy26
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSCALComponentwas setting an error without dealing with it. This caused the Component Viewer to not load at all when loading an invalid default URL.OSCALLoadernow passes anonError()function toOSCALComponentthat allows:OSCALComponentto throw an errorOSCALLoaderto catch that errorOSCALLoaderdisplays the existing, defined error of:"Something went wrong loading the OSCAL data {error}"Testing
By default the Component should display an error due to the issue usnistgov/oscal-content#69.
To test a successful component you must:
publicfolderdefaultOSCALComponentUrlinOSCALLoaderto:const defaultOSCALComponentUrl = http://localhost:3000/example-component.json