Display control info for all components #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuckerzp
commented
Aug 4, 2022
src/components/OSCALControl.js
Outdated
| parameters={control.params} | ||
| includeControlIds={props.includeControlIds} | ||
| modificationAlters={props.modificationAlters} | ||
| componentId={props.componentId} |
There was a problem hiding this comment.
This is the major change. I went ahead and cleaned up the map a bit as well.
There was a problem hiding this comment.
Since you're making a mess of the diff anyway :P can you update these to pass the props in a more similar/identical order?
There was a problem hiding this comment.
It is now in alphabetical order!
kylelaker
reviewed
Aug 4, 2022
tuckerzp
force-pushed
the
feature/display-control-parts-for-comp
branch
from
14bfea3
to
e4a860d
Compare
tuckerzp
force-pushed
the
feature/display-control-parts-for-comp
branch
from
e4a860d
to
329469b
Compare
kylelaker
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
component-uuidwas not being passed down to all controls.closes #421 as well as EasyDynamics/oscal-rest-service#100