EGRC-395: Change responsible roles to display the role name instead of numerical index #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change OSCALResponsibleRoles.js to display the name of each responsible role instead of the array index. This satisfies the change referenced in EGRC-395.
Removed a left over debugging statement.
Change the format of the test data in OSCALResponsibleRoles.test.js to be an array instead of an object. The name of the responsible role is now the "role-id" value of each object in the responsible roles array. This makes it consistent with recent changes to the OSCAL standard.
hreineck
changed the title
rgauss
suggested changes
Jun 14, 2021
rgauss
approved these changes
Jun 14, 2021
folksgl
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change OSCALResponsibleRoles.js to display the name of each responsible role instead of the numerical index.
This satisfies the change referenced in EGRC-395