Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add markdown support in metadata titles #550

Merged
merged 5 commits into from
Aug 11, 2022
Merged

Add markdown support in metadata titles #550

merged 5 commits into from
Aug 11, 2022

Conversation

kperk103
Copy link
Contributor

@kperk103 kperk103 commented Aug 9, 2022

This will add markdown support for metadata titles.

Part of #156.

kperk103 and others added 5 commits August 9, 2022 13:02
Add markdown support in metadata titles
fba8e2e 
This will add markdown support in metadata titles/
@tuckerzp
Merge branch 'develop' into feature/handle-metadata-title-markdown
ed4fb23
@kperk103
Merge branch 'develop' into feature/handle-metadata-title-markdown
39df2d6
Add OSCALMarkupLine instead of OSCALMarkdownProse
68be8bf 
This adds markdown support using OSCALMarkupLine instead
of OSCALMarkdownProse
Add {props.value} back in
a710964 
{props.value} had accidentally been removed in a Typography
which was making all the component tests fail.
@kperk103 kperk103 marked this pull request as ready for review August 10, 2022 17:28
@easy-dynamics-oscal-automation easy-dynamics-oscal-automation bot requested a review from a team August 10, 2022 17:28
@kperk103
Copy link
Contributor Author

This adds markdown support for metadata titles on each page, along with the titles in the drawer component as shown below:
Screenshot (21)

kylelaker
kylelaker approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@kylelaker kylelaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! This emphasizes for me that we need to do a better job of styling the drawer but I do like this a lot! Thanks!

@easy-dynamics-oscal-automation easy-dynamics-oscal-automation bot requested a review from a team August 10, 2022 23:26
@Bronstrom Bronstrom merged commit a16ee4c into develop Aug 11, 2022
@Bronstrom Bronstrom deleted the feature/handle-metadata-title-markdown branch August 11, 2022 13:29
@kylelaker kylelaker added the enhancement New feature or request label Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylelaker kylelaker kylelaker approved these changes

@Bronstrom Bronstrom Bronstrom approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kperk103 @kylelaker @Bronstrom @tuckerzp