Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded prop passing in loader #555

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Conversation

tuckerzp
Copy link
Contributor

@tuckerzp tuckerzp commented Aug 10, 2022

Testing the loader turned out to be a bit trickier than anticipated. For now removing some prop passing is a good enough improvement.

@tuckerzp tuckerzp force-pushed the feature/test-the-loader branch 2 times, most recently from 753ccf5 to d7f9a36 Compare August 10, 2022 15:28
@tuckerzp
Copy link
Contributor Author

I think that using just a Loader might not be the right approach. At the very least using something like an SSPLoader gives you more ability to actually load something.

@tuckerzp
Copy link
Contributor Author

I think to have the Reload button actually reload, it needs to not be disabled. To do that onResolutionComplete needs to be true. To make it true, we somehow need to do Loader.onResolutionComplete(). Which kinda goes back to the original issue of not being able to use a component's methods.

const onResolutionComplete = () => {
setIsResolutionComplete(true);
};

@tuckerzp tuckerzp changed the title Test OSCAL Loader Remove unneeded prop passing in loader Aug 12, 2022
@tuckerzp tuckerzp marked this pull request as ready for review August 12, 2022 20:40
@easy-dynamics-oscal-automation easy-dynamics-oscal-automation bot requested a review from a team August 12, 2022 20:40
@easy-dynamics-oscal-automation easy-dynamics-oscal-automation bot requested a review from a team August 12, 2022 20:48
@Bronstrom Bronstrom merged commit 3ab0398 into develop Aug 15, 2022
@Bronstrom Bronstrom deleted the feature/test-the-loader branch August 15, 2022 16:34
@kylelaker kylelaker added the bug Something isn't working label Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants