Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Citations, titles and, descriptions appear in markdown in backmatter #556

Merged
merged 4 commits into from
Aug 11, 2022

Conversation

schen2166
Copy link
Contributor

The Backmatter has markup language shown in prose in the screenshots below. Wrap them in a OSCALMarkupProse component so that it is easier for users to read.

Add OSCALMarkupProse to the citation, titles and descriptions in
markup text. They used to have `*`s show up around their fields.
@schen2166
Copy link
Contributor Author

This screenshot shows that the Title, and citation descriptions have been updated to be shown in markdown.

@schen2166 schen2166 marked this pull request as ready for review August 10, 2022 16:06
@easy-dynamics-oscal-automation easy-dynamics-oscal-automation bot requested a review from a team August 10, 2022 16:06
@schen2166 schen2166 linked an issue Aug 10, 2022 that may be closed by this pull request
@schen2166 schen2166 changed the title Make Citations, titles and, descriptions appear in markdown Make Citations, titles and, descriptions appear in markdown in backmatter Aug 10, 2022
src/components/OSCALBackMatter.js Outdated Show resolved Hide resolved
This makes slight changes to code so that the component tests
now pass.
@easy-dynamics-oscal-automation easy-dynamics-oscal-automation bot requested a review from a team August 11, 2022 22:03
@Bronstrom Bronstrom merged commit 3038e0f into develop Aug 11, 2022
@Bronstrom Bronstrom deleted the feature/backmatter-prose-to-markdown branch August 11, 2022 22:07
@kylelaker kylelaker added the enhancement New feature or request label Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle Markdown in Prose and Other Fields
5 participants