Remove underscore replacement workaround #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kylelaker
approved these changes
Aug 14, 2022
There was a problem hiding this comment.
@showalter Thank you (and thanks for signing the CLA)! Removing this undead code (technically I guess we ran it so it wasn't "dead" but it never really did anything) will make the flow quite a bit better and easier to read.
I really appreciate your contribution!
|
Sorry about the erroneous failure on the "Triage pull request" workflow; we'll also investigate that in the coming sprint (I'll open an issue Monday for that). To subsequent reviewers, please disregard that workflow's failure; it is not caused by this PR. |
tuckerzp
approved these changes
Aug 14, 2022
There was a problem hiding this comment.
@showalter thanks for the fix! I always love to see people other than us contributing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that usnistgov/oscal-content#58 has been resolved, the code removing underscores for the
statement-idis no longer needed.Closes #511