Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove profile URL workaround #568

Conversation

showalter
Copy link
Contributor

usnistgov/oscal-content#59 has been resolved, so this bit of code that fixes content URLs is no longer needed.

This can be tested by loading https://raw.githubusercontent.com/usnistgov/oscal-content/main/nist.gov/SP800-53/rev4/json/NIST_SP-800-53_rev4_MODERATE-baseline_profile.json into the profile viewer

Closes #502

@easy-dynamics-oscal-automation easy-dynamics-oscal-automation bot requested a review from a team August 15, 2022 21:16
Copy link
Contributor

@kylelaker kylelaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @showalter!

Fun fact: you can actually link directly into the viewer by using the ?url query string; for example https://oscal-viewer.msd.easydynamics.com/profile?url=https://raw.githubusercontent.com/usnistgov/oscal-content/main/nist.gov/SP800-53/rev4/json/NIST_SP-800-53_rev4_MODERATE-baseline_profile.json

Another fun fact: I actually think our TODO here was a little misleading. The linked issue on the oscal-content repo actually had nothing to do with this. That issue is actually for the fixJsonUrls() function (and #158). But somewhere through layers of redirection, copying and pasting, and misunderstandings we attributed this to the wrong upstream issue. Basically, at one point, NIST moved the content up a level in the oscal-content repo but it took some time for the actual published files to update and that's what this workaround was for. I've gone ahead and marked #158 as a good first issue and a chore.

I also forgot to write up that ticket about our mistake in our PR triage workflow, so don't mind the impending "PR Triage" workflow failure (that's to both @showalter and to the internal team). In the interim, I will manually kick off a review request.

@kylelaker kylelaker requested a review from a team August 15, 2022 22:37
@Bronstrom Bronstrom merged commit 3d973cf into EasyDynamics:develop Aug 16, 2022
@showalter showalter deleted the feature/remove-profile-url-workaround branch August 16, 2022 11:13
@kylelaker kylelaker added the bug Something isn't working label Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove code once OSCAL Content source issue is fixed
3 participants