Improve guidance modal title #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuckerzp
reviewed
Sep 8, 2022
tuckerzp
reviewed
Sep 8, 2022
tuckerzp
reviewed
Sep 8, 2022
tuckerzp
reviewed
Sep 8, 2022
| @@ -5,7 +5,9 @@ import OSCALControlGuidance from "./OSCALControlGuidance"; | |||
|
|
|||
| test("OSCALCatalog displays control guidance", async () => { | |||
There was a problem hiding this comment.
Since we are editing the test, I do not think that the description is entirely accurate about what is actually being tested. OSCALCatalog is not even rendered by this test.
tuckerzp
approved these changes
Sep 12, 2022
kylelaker
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the control's guidance so that a user can more easily read guidance across many different controls.
It updates the
Guidancebutton toRead Guidanceand adds the control's id and title to the modal.Closes #84