EGRC-400: Implement Profile Tests for Display of Controls and Control Modifications #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…red from the href in back matter test data
Displaying the alters nested tags inside of each other in an uneeded way. Instead only place typographies in a DialogContent tag
OSCALLoader was attempting to preform a React state update on an unmounted component. This indicates a memory leak and caused the tests to give warnings. We added a check to see if a component is mounted before updating state.
kkennedy26
requested review from
rgauss,
kylelaker,
folksgl,
Bronstrom,
tuckerzp,
hreineck,
zclarkEDC and
snorouzzadeh
rgauss
approved these changes
Jun 24, 2021
rgauss
reviewed
Jun 24, 2021
Bronstrom
approved these changes
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two tests were added within the
OSCALProfile.test. The first test within the function,testOSCALProfile, checks for the display of controls. The second test checks for the display of controls modifications by simulating a click of the modification's icon button. Bugs were also addressed within this PR: keys were added to child parts, parameters were fixed for html elements, and asynchronous tasks were cancelled inuseEffect().Two console errors may appear, in regards to key props for
OSCALControlImplementationImplReq, that will be addressed in another issue.To run tests: npm test or npm test -- --verbose