Display System Short Name and Description for SSP #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add to the System Characteristics section of the SSP Viewer to display the system's short name next to the system name, and display the description underneath the system name.
kylelaker
reviewed
Sep 9, 2022
Comment on lines
31
to
34
| {/* Render the system's short name in parentheses next to the name, | ||
| but only if the short name exists. */} | ||
| {props.systemCharacteristics["system-name-short"] && | ||
| " (" + props.systemCharacteristics["system-name-short"] + ")"} |
There was a problem hiding this comment.
Suggested change
| {/* Render the system's short name in parentheses next to the name, | |
| but only if the short name exists. */} | |
| {props.systemCharacteristics["system-name-short"] && | |
| " (" + props.systemCharacteristics["system-name-short"] + ")"} | |
| { | |
| // Render the system's short name in parentheses next to the | |
| // name, but only if the short name exists. | |
| props.systemCharacteristics["system-name-short"] && | |
| `(${props.systemCharacteristics["system-name-short"]})` | |
| } |
There was a problem hiding this comment.
This comment may still upset the linter -- but I want to use this (${}) with string interpolation instead of string concatenation. So this may need another npm run lint:fix once it's been applied.
| </Grid> | ||
| <Grid item xs={6}> | ||
| <Typography variant="body2"> | ||
| {props.systemCharacteristics["description"]} |
There was a problem hiding this comment.
Suggested change
| {props.systemCharacteristics["description"]} | |
| {props.systemCharacteristics.description} |
Address linter errors.
tuckerzp
approved these changes
Sep 12, 2022
kylelaker
approved these changes
Sep 12, 2022
kylelaker
deleted the
feature/display-ssp-short-name-and-description
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add to the System Characteristics section of the SSP Viewer to display the system's short name next to the system name, and display the description underneath the system name.
The short name functionality can be tested using FedRAMP's SSP Template.