Fix console warnings #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuckerzp
requested review from
rgauss,
kylelaker,
folksgl,
zclarkEDC and
kkennedy26
zclarkEDC
approved these changes
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This as well as commits in #48 fixes console warnings that occured when running
npm run testand when using the viewer.Note
Warning: findDOMNode is deprecated in StrictMode.still appears on the browser when running locally. This seems to be due to Material-UI components we are using. This might be dealt with in an v5 of Material-UI, but that version has not been released yet.StrictModeis typically used for development builds anyway, so this might not effect a released build.