EGRC-406: Display of Control Parameter Constraints in Profiles #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgauss
requested review from
kylelaker,
folksgl,
Bronstrom,
tuckerzp,
hreineck,
zclarkEDC and
kkennedy26
tuckerzp
reviewed
Jun 28, 2021
tuckerzp
reviewed
Jun 28, 2021
tuckerzp
reviewed
Jun 28, 2021
tuckerzp
approved these changes
Jun 28, 2021
hreineck
approved these changes
Jun 28, 2021
| index.toString() | ||
| ); | ||
| })} | ||
| {props.modificationDisplay} |
There was a problem hiding this comment.
Something to clean up in the future - Since this is its own component now, we probably don't need to pass in modificationDisplay, which is also its own discrete component. Might be cleaner to display them both from within ControlPart.
|
Reviewing now. |
zclarkEDC
reviewed
Jun 28, 2021
zclarkEDC
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
arrowYou can see the resulting dot badge and tooltip on hover by navigating to the Profile Viewer and viewing one of the FedRAMP profiles: