fix(control): change "Guidance" to "Discussion" #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Discussion" is the terminology used in the SP 800-53 PDF document, whereas "Guidance" is the term used within the OSCAL document. According to the [800-53rev5 Example][1] from NIST, `guidance` was retained from an earlier version of the data and tools reading and displaying it are free to make appropriate adjustments. To keep terminology consistent between the viewed version of the document and the expected PDF, we should use "Discussion". Within code, we should continue using "Guidance" (at least for now) because this is the terminology used in the source code. [1]: https://pages.nist.gov/OSCAL/concepts/layer/control/catalog/sp800-53rev5-example/
tuckerzp
approved these changes
Feb 28, 2023
Bronstrom
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Discussion" is the terminology used in the SP 800-53 PDF document,
whereas "Guidance" is the term used within the OSCAL document. According
to the 800-53rev5 Example from NIST,
guidancewas retained froman earlier version of the data and tools reading and displaying it are
free to make appropriate adjustments. To keep terminology consistent
between the viewed version of the document and the expected PDF, we
should use "Discussion". Within code, we should continue using
"Guidance" (at least for now) because this is the terminology used in
the source code.
Examples
Control List View
Control Discussion Modal