fix(prose): newline characters not displaying properly #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amics#619) The MarkupMultine method is used instead of the Markuline in the getTextSegment method because this is where we handle prose part. However, this method add an empty line at the begining which does not align well with the placeholder label. This empty line should be remove.
|
|
tuckerzp
changed the title
|
I updated the title and body to better fit conventional commits. Before committing, also be sure to run |
Your branch is up to date with 'fork/mpemy/display-remove-control-elements'.
Changes to be committed:
modified: src/components/OSCALControlProse.js
Fixing the failing build due to linting issue.
The line of code that was causing this issue have been addressed.
There was method MarkupLines that was added and then removed because it was not needed
I just forgot to delete it that is why lint was failing because I was importing a component that was not used and was inexistent.
I have simply deleted that reference.
…emy/oscal-react-library into mpemy/display-remove-control-elements merging these two branches so that I can complete this commit and fix the failing build
… symbol is contains in json prose.
|
Posting an up-to-date screenshot of SR-2.1 for convenience:
|
kylelaker
reviewed
Mar 10, 2023
There was a problem hiding this comment.
Can we just handle this in getTextSegment itself?
function getTextSegment(text, key) {
if (!text) {
return null;
}
return (
<Typography component="span" key={key}>
{
text.includes("\n") ?
<OSCALMarkupMultiline>{text}</OSCALMarkupMultiline> :
<OSCALMarkupLine>{text}</OSCALMarkupLine>
}
</Typography>
);
}
|
Thanks Kyle, I will do, I will handle that logic in getTextSegment. |
kylelaker
approved these changes
Mar 10, 2023
tuckerzp
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MarkupMultine method is used instead of the Markuline in the getTextSegment method because this is where we handle prose part. However, this method add an empty line at the begining which does not align well with the placeholder label. This empty line should be remove.
Just address a typo that was mistakenly inserted in the last commit.
closes #619