Lint Markdown With Github Actions #73
Conversation
tuckerzp
requested review from
kylelaker,
Bronstrom,
folksgl,
hreineck,
kkennedy26,
rgauss and
zclarkEDC
|
So because of Do we need to do the whole config file? Or should we only set values we care about (like line length and stern mode)? |
Removed redundant comments and instead linked rules from default markdownlint.yaml file. Also set line_length to 120 & stern mode to true based on discussion.
This adjusts the rules in the super-linter to run the specific linters we actually want. Additionally, go back to only linting changed files to reduce unrelated failures. We can go back to the full codebase likely after EGRC-168 and EGRC-412.
We should enable all rules by default, leverage their default configurations, and allow our configuration file to highlight where we are overriding the default values.
|
Looks like we should be okay to merge this without impacting #63. |
|
Also I want to highlight, I've broken my own rules here. This PR now addresses two somewhat unrelated issues. It:
This is the kind of creep on PRs that it can take care to avoid; so I wanted to highlight it since this is a good example. |
|
Looks good to me! Thanks for your help on this @kylelaker |
This expands #59 to add markdown linting to Github actions