-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metadata): Display keywords and remarks #747
Conversation
src/test-data/CommonData.js
Outdated
props: [ | ||
{ | ||
name: "keywords", | ||
value: "Keyword_1, Keyword_2,Keyword_3", | ||
}, | ||
], | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also have tests for:
{"props": []}
Displays nothing
{
"props": [
{
"name": "keywords",
"value": "",
}
]
}
Displays nothing
{
"props": [
{
"name": "keywords",
"value": "Keyword_1",
}
]
}
Displays 1 keyword
{
"props": [
{
"name": "keywords",
"value": "Keyword_1",
"ns": "https://test.easydynamics.com/ns/oscal"
}
]
}
Displays nothing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is terrific for initial viewing functionality. Thanks, @tuckerzp!
Implementation reads nicely, tests and stories are great, and overall the content displays cleanly! |
This adds the
OSCALMetadataKeywords
&OSCALMetadataRemarks
components.
closes #707
closes #710
Testing