Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metadata): Display keywords and remarks #747

Merged
merged 11 commits into from
Apr 4, 2023

Conversation

tuckerzp
Copy link
Contributor

@tuckerzp tuckerzp commented Mar 27, 2023

This adds the `OSCALMetadataKeywords` & `OSCALMetadataRemarks`
components.

closes #707
closes #710
@tuckerzp tuckerzp changed the title feat(metadata): Display keywords and remarks: feat(metadata): Display keywords and remarks Mar 27, 2023
Comment on lines 126 to 132
props: [
{
name: "keywords",
value: "Keyword_1, Keyword_2,Keyword_3",
},
],
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also have tests for:

{"props": []}

Displays nothing

{
  "props": [
    {
      "name": "keywords",
      "value": "",
    }
  ]
}

Displays nothing

{
  "props": [
    {
      "name": "keywords",
      "value": "Keyword_1",
    }
  ]
}

Displays 1 keyword

{
  "props": [
    {
      "name": "keywords",
      "value": "Keyword_1",
      "ns": "https://test.easydynamics.com/ns/oscal"
    }
  ]
}

Displays nothing

@tuckerzp tuckerzp marked this pull request as ready for review March 29, 2023 15:22
@tuckerzp tuckerzp requested a review from a team March 31, 2023 15:17
src/components/OSCALMetadata.js Outdated Show resolved Hide resolved
src/components/OSCALMetadata.js Outdated Show resolved Hide resolved
src/components/OSCALMetadata.js Outdated Show resolved Hide resolved
@easy-dynamics-oscal-automation easy-dynamics-oscal-automation bot requested a review from a team March 31, 2023 15:43
Copy link
Contributor

@kylelaker kylelaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is terrific for initial viewing functionality. Thanks, @tuckerzp!

@easy-dynamics-oscal-automation easy-dynamics-oscal-automation bot requested a review from a team March 31, 2023 19:08
@Bronstrom
Copy link
Contributor

Implementation reads nicely, tests and stories are great, and overall the content displays cleanly!

@Bronstrom Bronstrom merged commit 91cdfea into develop Apr 4, 2023
@Bronstrom Bronstrom deleted the tuckerzp/metadata-keywords-and-remarks branch April 4, 2023 00:48
@kylelaker kylelaker added the enhancement New feature or request label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support viewing metadata remarks Support viewing the metadata keywords property
3 participants