-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(backmatter): Support viewing base64 data #751
Conversation
This reworks how we resolve links in backmatter to not always assume data will be in an `rlink`.
This is a great start! Thanks for writing tests for this too! Based on a conversation we had earlier, it seems like maybe our current implementation has issues in some browsers, either because of size, corruption in the test data, or corruption as part of the resolution process. Can you please take a look at seeing if smaller images work or whether re-encoding the document used for testing solves the problem? I want to keep this in Draft status until we know the implementation actually works, or at least what the specific sharp edges are. |
Image was corrupted, I have updated it and things work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great use of #
(though we'll have to refactor it for TS eventually). Good work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very slick implementation! This PR taught me about private class members, which I had no idea existed in JS till now.
This reworks how we resolve links in backmatter to not always assume data will be in an
rlink
.The
BackMatterLookup
class will make resolving back matter a lot easier in the future.Testing
http://localhost:3000/system-security-plan/?url=https://raw.githubusercontent.com/EasyDynamics/oscal-demo-content/tuckerzp/base64/system-security-plans/ssp-example.json
The dataflow diagram is in base64
closes #671