Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profile): include-all and exclude directives are not resolved correctly #771

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

@easy-dynamics-oscal-automation easy-dynamics-oscal-automation bot requested a review from a team April 13, 2023 10:54
Copy link
Contributor

@kylelaker kylelaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a much better way to handle it -- removing the includeAll logic from the OSCALControl component is the right fix here. Thank you!

@easy-dynamics-oscal-automation easy-dynamics-oscal-automation bot requested a review from a team April 13, 2023 15:26
@kylelaker kylelaker changed the title Fixing IncludeAll and Exclude Control issues fix(profile): include-all and exclude directives are not resolved correctly Apr 13, 2023
@tuckerzp
Copy link
Contributor

tuckerzp commented Apr 14, 2023

@mpemy can you provide the files you used for testing here?

Take that back, I see it in commit message. Screenshots would be nice however.

@tuckerzp tuckerzp merged commit d6bbd23 into develop Apr 14, 2023
7 checks passed
@tuckerzp tuckerzp deleted the IncludeAll-ExcludeControls branch April 14, 2023 16:35
@kylelaker kylelaker added the bug Something isn't working label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants