feat(metadata): Support viewing revisions #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuckerzp
commented
Apr 18, 2023
tuckerzp
commented
Apr 18, 2023
tuckerzp
force-pushed
the
tuckerzp/metadata-revisions
branch
from
d559974
to
0013fc7
Compare
tuckerzp
force-pushed
the
tuckerzp/metadata-revisions
branch
from
ac5c553
to
14ddf62
Compare
kylelaker
approved these changes
Apr 20, 2023
There was a problem hiding this comment.
I am loving these TS reworks as you're going through. THANK YOU for that! I am good with the design and approach here. I'd love to make that table a more shared file...
Thank you for the tests!
I do wonder if we should have a display for a revision that isn't just a table row... but I guess we don't have anywhere to display that for now, so maybe we should just add it when we need it.
| @@ -60,7 +60,7 @@ export interface PropertyFilter { | |||
| export function propWithName( | |||
| props: Property[] | undefined, | |||
| name: string, | |||
| ns: string | undefined | |||
| ns?: string | undefined | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a modal with a table to view metadata revision history.
Closes #705
Testing
http://localhost:3000/catalog/?url=https://raw.githubusercontent.com/EasyDynamics/oscal-demo-content/tuckerzp/revision-example/catalogs/basic-test-catalog.json