Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow types workflow to pick up preleases #797

Merged
merged 4 commits into from
Apr 24, 2023
Merged

feat: allow types workflow to pick up preleases #797

merged 4 commits into from
Apr 24, 2023

Conversation

kylelaker
Copy link
Contributor

No description provided.

@easy-dynamics-oscal-automation easy-dynamics-oscal-automation bot requested a review from a team April 24, 2023 17:26
Bronstrom
Bronstrom reviewed Apr 24, 2023
View reviewed changes
Copy link
Contributor

@Bronstrom Bronstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks great! I would remove these console.logs though.

.github/workflows/update-types.yml Outdated Show resolved Hide resolved
.github/workflows/update-types.yml Outdated Show resolved Hide resolved
@easy-dynamics-oscal-automation easy-dynamics-oscal-automation bot requested a review from a team April 24, 2023 17:38
@easy-dynamics-oscal-automation easy-dynamics-oscal-automation bot requested a review from a team April 24, 2023 17:43
@tuckerzp tuckerzp merged commit c3ef92e into develop Apr 24, 2023
6 checks passed
@tuckerzp tuckerzp deleted the kyle/allow-prerelease-types branch April 24, 2023 18:07
@kylelaker kylelaker added the enhancement New feature or request label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bronstrom Bronstrom Bronstrom approved these changes

@tuckerzp tuckerzp tuckerzp approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kylelaker @Bronstrom @tuckerzp