fix: withdrawn controls are not displayed correctly #827
Conversation
packages/oscal-react-library/src/components/OSCALCatalogGroup.tsx
Outdated
Show resolved
Hide resolved
packages/oscal-react-library/src/components/oscal-utils/OSCALCatalogUtils.ts
Show resolved
Hide resolved
Control lists will use the line-through text decoration when withdrawn is true.
|
I'm noticing a few visual differences when testing this out: First of all, I notice a few styling differences. There is no gap between out top-level controls, the control's are white (was a very light gray), and the corners are no longer rounded. Before:
After:
Also, I see no click animation occurring on the top-level controls, and this may just be an issue on my end but when I open a control, the opening animation seems more sluggish. |
This is intentional as part of the switch from a |
So are you seeing an animation or not? I am confused about what exactly you're reporting here. |
| onEntered: () => !group && setListItemOpened(true), | ||
| unmountOnExit: true, | ||
| timeout: 0, |
There was a problem hiding this comment.
This is what we're using to prevent the long transitions. If you want to have animations but faster, then increase timeout. It is 0 because as-is on develop today, if you open AC-3 and then close it, you have to wait for the animation to close things below your viewport before you see any feedback that you clicked the button.
Maybe 0 is too jarring but suggest a value.
There was a problem hiding this comment.
I think 0 is fine for now. It is a pretty simple thing to change later if we want to.
There was a problem hiding this comment.
I changed this to 500
packages/oscal-react-library/src/components/OSCALCatalogGroup.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
After playing with the accordion more, I do think this looks and works better than what we previously had.
Thanks for your work on this @kylelaker
| onEntered: () => !group && setListItemOpened(true), | ||
| unmountOnExit: true, | ||
| timeout: 0, |
There was a problem hiding this comment.
I think 0 is fine for now. It is a pretty simple thing to change later if we want to.
… into kyle/withdrawn-controls
|
@tuckerzp and @Bronstrom I have updated the styling to be closer to the old styling but also slightly closer to the Accordion examples, which should make this easier to later reuse in Metadata (I will open a PR for that after this one has been merged) |
This makes it so that withdrawn controls can be expanded. It also makes it so that nested controls/groups display as withdrawn if a parent is withdrawn. - Withdrawn Control  - Withdrawn Control with children  --------- Co-authored-by: Zachary Tucker <ztucker@easydynamics.com>
This makes it so that withdrawn controls can be expanded. It also makes it so that nested controls/groups display as withdrawn if a parent is withdrawn.
Withdrawn Control
Withdrawn Control with children
