fix: make properties button smaller #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the "Open Properties" button to be only an icon. This then, in turn, makes it so we can put it in the Control Title areas and in the action areas for Back Matter resources. This should give us more flexibility about where and how to display this without "Open Properties" as text all over the page. A workaround is added to make it so that even a `disabled` properties button appears with a tooltip; this should make it easier to understand the purpose of the button. As explained in the inline comment, we can probably remove that when we add full editing support.
… into kyle/properties-slight-move
Sometimes we do in fact have buttons.
tuckerzp
approved these changes
May 4, 2023
2 tasks
Bronstrom
approved these changes
May 5, 2023
tuckerzp
pushed a commit
that referenced
this pull request
May 25, 2023
This changes the "Open Properties" button to be only an icon. This then, in turn, makes it so we can put it in the Control Title areas and in the action areas for Back Matter resources. This should give us more flexibility about where and how to display this without "Open Properties" as text all over the page. A workaround is added to make it so that even a `disabled` properties button appears with a tooltip; this should make it easier to understand the purpose of the button. As explained in the inline comment, we can probably remove that when we add full editing support. Finally, the tests are reworked to centralize testing in a single file and to actually test the contents and different properties there. Tests are left in `OSCALMetadata.test.tsx` to have a test for a consumer of the API. 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the "Open Properties" button to be only an icon. This then,
in turn, makes it so we can put it in the Control Title areas and in the
action areas for Back Matter resources. This should give us more
flexibility about where and how to display this without "Open
Properties" as text all over the page.
A workaround is added to make it so that even a
disabledpropertiesbutton appears with a tooltip; this should make it easier to understand
the purpose of the button. As explained in the inline comment, we can
probably remove that when we add full editing support.
Finally, the tests are reworked to centralize testing in a single file and
to actually test the contents and different properties there. Tests are left
in
OSCALMetadata.test.tsxto have a test for a consumer of the API.