fix: large control display "squishes" tabs for Component controls #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Historically, our display of controls for components has been a bit fragile, where if the control side got too large, it would squish into the component tabs and cause overflow, truncation, or wrapping. This is suboptimal and instead we should use a behavior more like what we do in OSCALControlGroups where we set a specific side on Grid items. The same numbers are used in both places. Because of the complexity around handling fragments, I did not rework this into a shared component. No other styles for the component have changes to align it with Controls (though we should do that).
kylelaker
commented
May 11, 2023
packages/oscal-react-library/src/components/OSCALControlImplementationImplReq.js
Outdated
Show resolved
Hide resolved
kylelaker
commented
May 11, 2023
packages/oscal-react-library/src/components/OSCALControlImplementationImplReq.js
Outdated
Show resolved
Hide resolved
tuckerzp
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, our display of controls for components has been a bit
fragile, where if the control side got too large, it would squish into
the component tabs and cause overflow, truncation, or wrapping. This is
suboptimal and instead we should use a behavior more like what we do in
OSCALControlGroups where we set a specific side on Grid items. The same
numbers are used in both places.
Because of the complexity around handling fragments, I did not rework
this into a shared component. No other styles for the component have
changes to align it with Controls (though we should do that).