Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rendering components before loading #859

Merged
merged 2 commits into from
May 12, 2023
Merged

fix: rendering components before loading #859

merged 2 commits into from
May 12, 2023

Conversation

tuckerzp
Copy link
Contributor

OSCAL documents were being rendered before loading was complete.

@tuckerzp
fix: rendering components before loading
3a71fe4 
OSCAL documents were being rendered before loading was complete.
kylelaker
kylelaker approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@kylelaker kylelaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate this fix but I guess it makes sense. We really ought to look into better loading handling.

@Bronstrom Bronstrom merged commit d91b7d0 into develop May 12, 2023
6 checks passed
@Bronstrom Bronstrom deleted the tuckerzp/fix-tests branch May 12, 2023 16:50
@kylelaker kylelaker added the bug Something isn't working label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylelaker kylelaker kylelaker approved these changes

@Bronstrom Bronstrom Bronstrom approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tuckerzp @kylelaker @Bronstrom