fix: storybook crashes when anchor is triggered #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes a few changes: primarily `react-router-dom` is no longer used for the link and `IconButton` (which has an `href` attribute) is used instead. Additionally, to fix some "shakiness" when resources are hovered over, additional padding is added to the containing Stack (by increasing the `min-height`).
Bronstrom
approved these changes
May 17, 2023
tuckerzp
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a few changes: primarily
react-router-domis no longer usedfor the link and
IconButton(which has anhrefattribute) is usedinstead. Additionally, to fix some "shakiness" when resources are
hovered over, additional padding is added to the containing Stack (by
increasing the
min-height).